Commit
1 year ago
gh-36936: `src/sage/doctest/forker.py`: Show '# [failed in baseline]' earlier <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes #1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> The note "[failed in baseline]" already appears in the doctest failure summary. Here we add the note also to the `sage -t` line during doctesting: https://github.com/sagemath/sage/actions/runs/7281940815/job/19843412065 ?pr=36936#step:11:2744 ``` sage -t --random-seed=256963700569517996050547927079750684585 src/sage/combinat/combinatorial_map.py [75 tests, 0.05 s] sage -t --random-seed=256963700569517996050547927079750684585 src/sage/combinat/cluster_algebra_quiver/quiver.py # [failed in baseline] [320 tests, 3.73 s] sage -t --random-seed=256963700569517996050547927079750684585 src/sage/combinat/composition_signed.py [20 tests, 0.16 s] ``` https://github.com/sagemath/sage/actions/runs/7281940815/job/19843412065 ?pr=36936#step:11:9192 ``` sage -t --random-seed=256963700569517996050547927079750684585 src/sage_setup/setenv.py [0 tests, 0.00 s] sage -t --random-seed=256963700569517996050547927079750684585 src/sage_setup/clean.py # [failed in baseline] ********************************************************************** File "src/sage_setup/clean.py", line 104, in sage_setup.clean._find_stale_files Failed example: for f in stale_iter: if f.endswith(skip_extensions): continue if '/ext_data/' in f: continue print('Found stale file: ' + f) Expected nothing Got: Found stale file: sage/tests/books/judson-abstract- algebra/homomorph-sage-exercises.py Found stale file: sage/tests/books/judson-abstract-algebra/actions- sage-exercises.py Found stale file: sage/tests/books/judson-abstract- algebra/homomorph-sage.py ``` The changes in the code that implement this are also preparation for: - #36558. <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes #12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### :memo: Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [ ] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### :hourglass: Dependencies <!-- List all open PRs that this PR logically depends on - #12345: short description why this is a dependency - #34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: https://github.com/sagemath/sage/pull/36936 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee, Matthias Köppe
Author
Release Manager
Loading