Commit
2 years ago
gh-35578: refactor: improve initialization of combinatorial polyhedron <!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> <!-- For example, instead of "Fixes #12345", use "Add a new method to multiply two integers" --> ### :books: Description Motivated by #34773. The initialization of `CombinatorialPolyhedron` is rather complicated. Changing functionality is difficult this way, so we extract some of the initialization to dedicated methods. ### :memo: Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### :hourglass: Dependencies <!-- List all open PRs that this PR logically depends on - #12345: short description why this is a dependency - #34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: https://github.com/sagemath/sage/pull/35578 Reported by: Jonathan Kliem Reviewer(s): Jonathan Kliem, Matthias Köppe
Author
Release Manager
Loading