Commit
2 years ago
gh-36849: Problem with orientations of simplices in simplicial complex maps. Problem with orientation of simplices in simplicial complex maps <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes #1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> In rare cases, Sage incorrectly computes the chain complex map associated to a map of simplicial complexes. The problem is that the orientation of each simplex in the image is not correctly compared to its actual orientation in the codomain: an edge `(f(v), f(w))` is not compared correctly to see whether the actual simplex in the codomain is stored as `(f(v), f(w))` or `(f(w), f(v))`. I think that the default sorting of vertices (and hence simplices) means that this usually doesn't come up, but it can arise when the vertices do not have an obvious ordering. See https://ask.sagemath.org/question/74754/chain-morphism-between- subdivisions/ for one such case. <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes #12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### :memo: Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [X] The title is concise, informative, and self-explanatory. - [X] The description explains in detail what this PR is about. - [X] I have linked a relevant issue or discussion. - [X] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### :hourglass: Dependencies <!-- List all open PRs that this PR logically depends on - #12345: short description why this is a dependency - #34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: https://github.com/sagemath/sage/pull/36849 Reported by: John H. Palmieri Reviewer(s): Travis Scrimshaw
Author
Release Manager
Loading