Commit
2 years ago
gh-36095: Implementing a generic one method for unital algebras <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes #1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> We implement a generic `one()` method for unital algebras in order to fix the following: ```python sage: S2 = simplicial_complexes.Sphere(2) sage: H = S2.cohomology_ring(QQ) sage: C = cartesian_product([H, H]) sage: C.one() # this raises an error currently B[(0, (0, 0))] + B[(1, (0, 0))] ``` ### :memo: Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. ### :hourglass: Dependencies <!-- List all open PRs that this PR logically depends on - #12345: short description why this is a dependency - #34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: https://github.com/sagemath/sage/pull/36095 Reported by: Travis Scrimshaw Reviewer(s): Frédéric Chapoton
Author
Release Manager
Loading