nvda

0cdb8932 - If AppVeyor install of NVDA fails, ensure installer log can be uploaded successfully

If AppVeyor install of NVDA fails, ensure installer log can be uploaded successfully Fixes #13083 Summary of the issue: When NVDA's installer fails to install NVDA and the process is still running the log from the failed installation cannot be uploaded and all tests fail since they're executed against broken installation of NVDA. Description of how this pull request fixes the issue: Exceptions raised by wait-process are properly caught which in practice means that the block of code responsible for interrupting the build if installer fails to exit in the specified timeout is executed - previously it didn't. Since AppVeyor function used to upload build artifacts is unable to upload files which are in use if the installer process is still running we copy the log and upload it instead of the, currently locked, original file. Testing strategy: With a commit in which I've simulated a crash of nvda_slave inspected this build log and made sure that: The message that install process timed out is shown the build is interrupted when NVDA fails to install The installer log can be downloaded from the artifacts.