nvda

32a8613c - No longer remove failed add-ons installs and warn when add-on installs, removals and updates cannot complete (#15937)

No longer remove failed add-ons installs and warn when add-on installs, removals and updates cannot complete (#15937) Reverts #15921 Closes #12823 Addresses the most likely cause of #15719 Hopefully fixes #15927 Summary of the issue: PR #15921 started removing all add-ons which failed to be installed without showing warnings to the user. Users generally expect NVDA to attempt installation / removal of add-ons on the next restart if they failed, to have a warning when one of these operations didn't succeed and not to be able to install add-on which is not fully removed from Add-ons Store. Description of user facing changes When one or more add-ons fails to be updated, uninstalled or installed, NVDA shows an appropriate warning on startup. Installation / removal is attempted on the next restart. When add-on is pending remove it is shown in the Add-ons Store along with the 'pending remove' status. All add-ons which are no longer present on disk are removed from the list of pending installs to hopefully improve #15719. Description of development approach NVDA stores add-ons whose installation / removal failed in a list. All these add-ons are not loaded ,but shown in the Add-ons Store. These lists are used to determine what warnings should be shown to the user. List of pending installs is cleaned-up from add-ons which are no longer present on disk, excluding these which failed to be installed, as their install is going to be attempted on the next restart.