nvda
3f9151fe - Add winBindings for crypt32 and replace raw ctypes calls. Move some structures into winBindings.crypt32 also. (#18956)

Commit
111 days ago
Add winBindings for crypt32 and replace raw ctypes calls. Move some structures into winBindings.crypt32 also. (#18956) ### Link to issue number: None ### Summary of the issue: Continuing to move to 64 bit, crypt32.dll is one of the last dlls that requires correct ctypes definitions. ### Description of user facing changes: None ### Description of developer facing changes: Some structures have been moved from `updateCheck` to `winBindings.crypt32`. ### Description of development approach: Add winBindings.crypt32 required definitions, and move some structures. ### Testing strategy: Spoof `buildVersion.updateVersionType` to `stable`, and checked for and downloaded an update. Note however that as NV Access's TLS certificate is trusted by my system, the changed code shouldn't have been exercised. System and unit tests. Further testing tbd ### Known issues with pull request: None ### Code Review Checklist: - [x] Documentation: - Change log entry - User Documentation - Developer / Technical Documentation - Context sensitive help for GUI changes - [ ] Testing: - Unit tests - System (end to end) tests - Manual testing - [x] UX of all users considered: - Speech - Braille - Low Vision - Different web browsers - Localization in other languages / culture than English - [x] API is compatible with existing add-ons. - [x] Security precautions taken. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Sascha Cowley <16543535+SaschaCowley@users.noreply.github.com> Co-authored-by: Sean Budd <sean@nvaccess.org>
Parents
Loading