Merge pull request #17922 from nvaccess/remoteServerFollower
Summary of the issue:
NVDA menu -> Tools -> Remote -> Connect...
Set mode to "Allow this machine to be controlled" and server to "Host locally". Set a key.
Connect. Observe that an error is logged and no connection cue is played.
The issue arrises because the clients parameter to FollowerSession.handleChannelJoined does not have a default, and the in-built relay server sends None when no clients are connected.
This is not an issue for LeaderSession, as its handleChannelJoined already supports clients=None.
Description of user facing changes
No error is logged, and the connection sound is heard.
Description of development approach
Fixed remoteClient.session.FollowerSession.handleChannelJoined:
The clients parameter is now typed as accepting a dict or None, and defaults to None.
The method body already handled clients being None, so no further changes were necessary.