nvda

544ccb16 - WasapiWavePlayer.feed: Log exceptions but don't raise them. (#16738)

WasapiWavePlayer.feed: Log exceptions but don't raise them. (#16738) Fixes #16722. Summary of the issue: When a client disconnects from a Remote Desktop session without exiting NVDA on the server, WASAPI can throw ERROR_TOO_MANY_FILES, which is not a WASAPI error code and thus not expected by the C++ code. E_NOTFOUND is also possible, probably thrown by IMMDeviceEnumerator::GetDefaultAudioEndpoint. WasapiWavePlayer.feed raises an exception, which breaks the oneCore driver because it isn't expecting exceptions. Speech is broken henceforth. Description of user facing changes Speech is no longer silent after disconnecting from and reconnecting to a Remote Desktop session. Description of development approach I changed WasapiWavePlayer.feed to log exceptions and return without raising them. I could have tweaked the C++ code to handle ERROR_TOO_MANY_FILES and E_NOTFOUND as well as the codes it already handles (AUDCLNT_E_DEVICE_INVALIDATED and AUDCLNT_E_NOT_INITIALIZED). However, I figured it was best to make this code more resilient in general by catching exceptions, especially given that WinmmWavePlayer.feed also catches exceptions.