nvda
56763f03 - Add-on Store: use Yes/No buttons with incompatibility question dialogs, instead of OK/Cancel buttons; improve related translator comments (#15015)

Commit
3 years ago
Add-on Store: use Yes/No buttons with incompatibility question dialogs, instead of OK/Cancel buttons; improve related translator comments (#15015) Fixes #15000 Summary of the issue: Dialogs used when installing, enabling, or upgrading to, incompatible add-ons, asked yes or no questions to the user. However, such dialogs used OK and Cancel as their buttons, which didn't really make sense. Description of user facing changes These three dialogs now have Yes and No buttons. Incidentally, added a newline before the question in each dialog, as commented in the original issue. This can be reverted separately if undesirable. Description of development approach Replaced the ErrorAddonInstallDialogWithCancelButton class, with a new class called ErrorAddonInstallDialogWithYesNoButtons. Removed ErrorAddonInstallDialogWithCancelButton, since it wasn't used anywhere other than for these three dialogs in gui/_addonStoreGui/controls/messageDialogs.py. Added a newline to separate explanation from actual question in these dialogs. Enhanced (hopefully) some translator comments I noticed along the way, as follow: Created a more accurate translator comment for the incomparable version during update message. Made the translator comment less ambiguous, for the message used when an add-on is being installed but is too old to be compatible. Made the translator comment more accurate, for the message used when enabling an add-on too old to be compatible. Fixed a typo in another translator comment.
Author
Parents
Loading