nvda
96468c2c - winVersion.getWinVer: set update revision to 0 if UBR cannot be accessed via Widows Registry (#18621)

Commit
195 days ago
winVersion.getWinVer: set update revision to 0 if UBR cannot be accessed via Widows Registry (#18621) Closes #18617 Summary of the issue: In Windows 8.1, attempting to access Windows Registry to obtain update build revision (UBR) results in file not found error and the snapshot installer no longer starts. Description of user facing changes: Alpha/beta builds can be installed on Windows 8.1 again. Description of developer facing changes: If UBR cannot be obtained, build revision will be set to 0. Description of development approach: in winVersion module, put build revision assignment inside a try block, and set build revision to 0 if an exception occurs while accessing the registry. In Windows 8.1, this will result in NVDA reporting "6.3.9600.0" which is acceptable as Windows 8.1 (client version) is no longer supported by Microsoft (Windows Server 2012 R2 is supported under extended security updates program). Testing strategy: Tested in Windows 8.1 virtual machine: * nvda_snapshot_beta-51631,a18ebb3 cannot be started * nvda_snapshot_try-win81UBRRegKey-37682,e6d54c46 works normally Thanks to @wmhn1872265132 for testing Known issues with pull request: None
Author
Parents
Loading