nvda

b3232697 - COM registration fixing tool: don't run when cancelling with alt+f4 on the Intro screen (#18094)

COM registration fixing tool: don't run when cancelling with alt+f4 on the Intro screen (#18094) Fixes #18090 Summary of the issue: When running the COM registration fixing tool (NVDA menu -> tools -> Run COM Registration fixing tool...), it shows an intro screen with Continue and Cancel buttons. Activating Cancel or pressing escape correctly exits the tool without running it, however pressing alt+f4 on this screen incorrectly allows it to try and continue. `ShowModal` on this dialog returns the following: * Activating Continue button: wx.OK * Activating cancel button: wx.Cancel * Pressing escape: wx.Cancel * Pressing alt+f4: 0 Description of user facing changes * when pressing alt+f4 on the COM registration fixing tool's intro screen, the tool is correctly cancelled and does not try and run. Description of development approach If the response from the intro dialog's `showModal` call is not wx.OK, then cancel. Otherwise, continue to run the tool. Previously, it would cancel if the value was wx.Cancel, and run otherwise. In otherwords, anything other than OK will now cause it to cancel. Testing strategy: * [x] Tested manually in Python console. * [x] Test COM registration tool with a signed try build. Steps include: * launching tool and pressing continue. It should continue. * Launching tool and pressing cancel. It should cancel. * Launching tool and pressing escape. It should cancel. * Launching tool and pressing alt+f4. It should cancel. Known issues with pull request: Perhaps _ContinueCancel dialog should return wx.Cancel on alt+f4. Though I am guessing that would involve custom handling of the close event. It is also possible that making it inherit from the newer `gui.messageDialog.MessageDialog` and doing any necessary refactoring could have different results? However, for now I went with the smallest change.