nvda
d33bc929 - Fix bugs when attempting to install add-ons requiring a newer NVDA release (#19420)

Commit
25 days ago
Fix bugs when attempting to install add-ons requiring a newer NVDA release (#19420) ### Link to issue number: Fixes #19260 Fixes #19261 ### Summary of the issue: When attempting to install an add-on which requires a newer version of NVDA via File Explorer: * If no incompatible add-ons are installed, the installation fails silently. * If disabled incompatible add-ons are installed, the incompatible add-ons dialog is erroneously shown, followed by the error dialog. ### Description of user facing changes: Attempting to install such an add-on from File Explorer shows the correct error dialog and does not show the incompatible add-ons dialog. ### Description of developer facing changes: None. ### Description of development approach: Removed code that created and showed a `IncompatibleAddonsDialog` from `ErrorAddonInstallDialog._addButtons`. As best as I can tell, this code should not have been here. Presumably in a past rewrite its removal was missed and this issue has simply only now been discovered. ### Testing strategy: Built a launcher and installed. Attempted to install an add-on which specified a minimum NVDA version of 2027.1: * With no other add-ons installed; * With an incompatible add-on installed and disabled; and * With an incompatible add-on installed and force-enabled. ### Known issues with pull request: None.
Author
Parents
Loading