nvda
e07c5347 - Keep review copy marker across equivalent review object instances (#20300)

Commit
40 days ago
Keep review copy marker across equivalent review object instances (#20300) Closes #13864 ### Summary of the issue: Review copy markers are stored on the current review object. Some actions, such as find or go to, can move the review position to an equivalent text container represented by a different object instance. When this happens, NVDA+F10 reports that no start marker is set. ### Description of user facing changes: After marking the start of text with NVDA+F9, users can move with find or go to and still use NVDA+F10 to select and copy the marked range. ### Description of developer facing changes: Review copy marker state is now stored on the global commands instance instead of the review object. The marker is only reused when the current TextInfo implementation matches and the text container is equivalent. ### Description of development approach: This keeps the change limited to the review copy commands. It continues to use the existing TextInfo APIs for comparing ranges, updating selection, and copying text. It does not change review cursor routing or TextInfo backends. ### Testing strategy: Added unit tests covering review copy markers when the review object instance changes but still represents the same text container, and when it represents a different text container. Manual testing: 1. Open a multiline edit control such as Notepad. 2. Move the review cursor to the start of the text to copy. 3. Press NVDA+F9. 4. Use find or go to to move to the end position. 5. Press NVDA+F10 once and confirm the marked range is selected. 6. Press NVDA+F10 again and confirm the selected text is copied. 7. Move to a different edit control and confirm NVDA+F10 does not reuse the previous marker. ### Known issues with pull request: None known.
Author
Parents
Loading