nvda
e908d2c0 - Fix Remote Access speech when follower has no connected audio render endpoints (#18575)

Commit
234 days ago
Fix Remote Access speech when follower has no connected audio render endpoints (#18575) ### Link to issue number: Fixes #18544 ### Summary of the issue: When using NVDA Remote Access, if the controlled computer has no audio output devices enabled, speech is not sent to the controlling computer. ### Description of user facing changes: Speech is now sent, even if the controlled computer has no audio output devices enabled. ### Description of developer facing changes: None ### Description of development approach: The issue was caused by `nvwave.playWaveFile` raising an exception if no render endpoints were available. To mitigate this, `_remoteClient.cues._playCue` now handles exceptions raised by `playWaveFile`. ### Testing strategy: Configured the source copy of NVDA to connect as follower automatically on startup. Disabled all audio output devices and launched NVDA from source. Connected on a second device as leader and checked that speech was received. ### Known issues with pull request: The underlying problem has not been resolved. As this involves a change in API behaviour, I will implement it in a separate PR. ### Code Review Checklist: - [x] Documentation: - Change log entry - User Documentation - Developer / Technical Documentation - Context sensitive help for GUI changes - [x] Testing: - Unit tests - System (end to end) tests - Manual testing - [x] UX of all users considered: - Speech - Braille - Low Vision - Different web browsers - Localization in other languages / culture than English - [x] API is compatible with existing add-ons. - [x] Security precautions taken. <!-- Please keep the following --> @coderabbitai summary
Author
Parents
Loading