nvda

e928f025 - Use only supported log levels for command line option (second attempt) (#14444)

Use only supported log levels for command line option (second attempt) (#14444) When starting NVDA with an unsupported command line parameter, you get the following suggestion for log level in the error message: [-l {10,12,15,20,30,40,50,100}] Launching NVDA with log level set to 30, 40 or 50 leads to undesirable behaviours: • an empty value in the log level combo-box in NVDA's general settings. • NVDA+F1 does not open the log • NVAccess does not want log level WARNING, ERROR or CRITICAL as written by @michaelDCurran in Use only supported log levels for command line option #14406 (comment): We don't ever want users providing logs to us at level warning, error or critical as they are simply not useful as they drop too much information and therefore just waste time for the user and us. Also, the description of the -l option is erroneous in the user guide and in the help text for command line since it indicates that the default value for this option is WARNING. Instead, the default behaviour (i.e. when the option is not specified) is to follow what comes from NVDA config; and if there is nothing in the user's config, the default config spec specifies that the log level is INFO. Description of user facing changes • Only supported log levels are indicated in the error message when a wrong parameter is passed to NVDA. • Only supported log level can now be used from command line, i.e. 10=debug, 12=I/O, 15=debugWarning, 20=info and 100=off • The description of the -l option is updated in the user guide and in the help text for command line Description of development approach • Changed the information passed to the command line parser. • Updated the available log levels in the user guide and the command line help; also removed the indication related to "default" since it was just adding confusion. For more clarity I may have rewritten the option description in command line help and in the user guide to something like "Forces the log level". I have not done this since it is not done for other options such as -c, --log-file, etc.