nvda
eaab6f9b - Bugfix for displayed gesture identifier containing numlock modifier (#19213)

Commit
161 days ago
Bugfix for displayed gesture identifier containing numlock modifier (#19213) Link to issue number: Fixes #19214 Summary of the issue: When gestures include numpad operators (numpad plus, numpad minus, numpad multiply and numpad divide) and are defined with numlock on, they do not appear correctly in input gesture dialog, e.g. "num lock" instead of "num lock+numpad plus") Description of user facing changes: Gestures including numpad operators with num lock on are now correctly displayed in the input gesture dialog. Description of developer facing changes: N/A Description of development approach: In kayboard gestures identifiers, numlock can be considered a modifier or a main key name, depending on the situation: considered a modifier when combined with numpad operators, i.e. when numlock is on (but not currently physically pressed) and a numpad operator is presseed considered a main key name in all other other cases, i.e. when physically pressed (alone or with other modifiers such as control or shift) In KeyboardInputGesture.getDisplayTextForIdentifier sort key name with normal modifiers, then numlock and then main key name.
Author
Parents
Loading