nvda
f64f3bd0 - Make input help message for math navigation translatable, and exclude from input gestures dialog (#19860)

Commit
3 days ago
Make input help message for math navigation translatable, and exclude from input gestures dialog (#19860) Interim fix for #19815 ### Summary of the issue: Math navigation commands report the developer docstring in input help mode. This is neither translatable nor relevant to end users. Users can also assign gestures to this script, which could lead to unexpected results. ### Description of user facing changes: Math navigation gestures now have a translatable input help message. The single script which dispatches to MathCAT is no-longer available in the input gestures dialog. ### Description of developer facing changes: `mathPres.MathCAT.MathCAT.MathCATInteraction.script_navigate` has been removed from the public API. ### Description of development approach: Renamed `mathPres.MathCAT.MathCAT.MathCATInteraction.script_navigate` to `_do_navigate`. Since `mathPres.MathCAT.MathCAT.MathCATInteraction.getScript` has custom logic for returning this method, it does not need the `script_` prefix. Since we want it to have a docstring (so something is reported in input help mode), this is also the only way of removing it from the input gestures dialog. After the definition of `mathPres.MathCAT.MathCAT.MathCATInteraction._do_navigate`, set its docstring to a translatable, user-friendly string. Since static analysis tools only consider string literals immediately following function headers as docstrings, this should preserve the developer docstring while providing a more appropriate value for input help. ### Testing strategy: Ran from source. Interracted with math. Activated input help. Ensured that pressing arrows, space, enter, and numrow keys reported the expected message. Opened the input gestures dialog while interacting with math and checked that the navigation command was not present. ### Known issues with pull request: This is a temporary fix. Longer term we want to move to discrete gestures per MathCAT navigation command.
Author
Parents
Loading