nvda
f75f58e1 - Remove the option for Remote Access to play beeps (#18100)

Commit
267 days ago
Remove the option for Remote Access to play beeps (#18100) Closes #18087  Summary of the issue: Remote Access currently has the option to choose between sounds and beeps for audio cues. This is extra code that we have to maintain, and is not an option that is present elsewhere in NVDA. Description of user facing changes The option has been removed. Remote Access will only play audio cues. Description of development approach 1. In `gui.settingsDialogs.RemoteSettingsPanel`, removed the checkbox and references thereto that controlled this setting. 2. In `_remoteClient.cues`, removed the code that playes beep sequences from `_playCue`, including `shouldPlaySounds`, as this is now always `True`. Removed each `beeps` field from the various cues, and edited the type definition of `Cue` to no longer include this field. 3. In `tones`, removed `beepSequence`, `beepSequenceAsync`, and associated datatypes and imports. 4. Remove the `playSounds` option from the config spec, and the rename from the `upgradeConfigFrom_16_to_17` function. 5. Edit the user guide to no longer refer to the "Play sounds instead of beeps" option. Testing strategy: 1. Tested opening, closing, and saving the Remote Access settings to ensure that they still work as expected. 2. Started a Remote Access session, and sent the clipboard to make sure various cues still work as expected. 3. Unit tests. Known issues with pull request: None known
Author
Parents
Loading