open-ui
ed9de347 - Switch proposal (#785)

Commit
1 year ago
Switch proposal (#785) * chore: initialize switch explainer * Update switch explainer * Update switch.explainer.mdx * Update non-goals * Update switch.explainer.mdx * added anatomy images and updated formatting * fix: improve question rendering Improves the rendering of questions in editors drafts. A little more padding, no break between question and number, mobile styling, margin between elements. * Update switch.explainer.mdx * Incorporate feedback from @scottaohara about accessibility https://github.com/openui/open-ui/pull/785#discussion_r1279305903 https://github.com/openui/open-ui/pull/785#discussion_r1279310394 https://github.com/openui/open-ui/pull/785#discussion_r1279318059 https://github.com/openui/open-ui/pull/785#discussion_r1279300189 * Added link to parallel efforts * Update accessibility section Remove sentence about AT exposure on @scottaohara's recommendation. * Updated DOM structure proposal to match elements approach Namings need to be discussed. * Update research format for immediate action research * Added link to research page * Update DOM structure to reuse trackside element * fix image urls * add screen recordings of prior art * comment instructions * update anatomy and parts section * clarified sample size for analysis * the antonym of toggled is untoggled https://github.com/openui/open-ui/pull/785#discussion_r1291783460 * added backlink to issue for reference * typo * updated the explainer - Renamed from editor's draft to explainer - Changed the menu section to active proposals - Added a section where the switch attribute and the element are being compared - Added explanatory images for edge cases - Added two small paragraphs in the design section about user interaction and styleability * Update site/src/pages/components/switch.explainer.mdx Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com> * Update site/src/pages/components/switch.explainer.mdx Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com> * Update site/src/pages/components/switch.explainer.mdx Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com> * save hotlinked images locally and add attributions * remove the proposal for type="submit" As discussed on the initial pull request (https://github.com/openui/open-ui/pull/785#discussion_r1396395740), treating the switch as a button with submission capabilities has potential accessibility issues as mentioned by @scottaohara. * clarify text * specify interaction patterns * clarify checked state * added allowed content resolution * add info about safari implementation of input switch * update from comments on the PR --------- Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com> Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
Author
Parents
Loading