connectedhomeip
[Closures] Update Closure dimension cluster as per latest specification
#38424
Merged
Overview
Commits
8
Changes
View On GitHub

[Closures] Update Closure dimension cluster as per latest specification #38424

mergify merged 8 commits into project-chip:master from senthilku:closure/closure_dimension_cluster_spec_update_changes
sabollim-silabs
sabollim-silabs27 days ago (edited 26 days ago)

This PR aims to add:

XML code generated using Alchemy for closure dimension cluster spec updates
ZAP-generated code based on the closure dimension specification updates.
Closure dimension server code updates as per the new specification

Reference Specification SHA ba6044ef35590c19ba55475654c16440ac2982bd used for this PR

Testing

New files are built successfully locally. (Closure App CI is currently disabled during the rework - local tests are the only validation)

sabollim-silabs sabollim-silabs requested a review 27 days ago
sabollim-silabs sabollim-silabs requested a review 27 days ago
sabollim-silabs sabollim-silabs marked this pull request as draft 27 days ago
sabollim-silabs sabollim-silabs changed the title [Closures] Update Closure dimension cluster as per latest specification [Closures] [WIP] Update Closure dimension cluster as per latest specification 27 days ago
github-actions github-actions added darwin
github-actions github-actions added controller
github-actions github-actions added app
satyanaag-silabs Update Closure dimension cluster as per latest specification
8fc31eda
sabollim-silabs sabollim-silabs force pushed from 9feb7956 to 8fc31eda 26 days ago
github-actions
github-actions26 days ago

PR #38424: Size comparison from 88bff31 to 8fc31ed

Full report (1 build for stm32)
platform target config section 88bff31 8fc31ed change % change
stm32 light STM32WB5MM-DK FLASH 462928 462928 0 0.0
RAM 141488 141488 0 0.0
satyanaag-silabs Adding missing zap files
117a5be0
satyanaag-silabs Updating server implementation as per new spec changes
ebf673e2
mkardous-silabs
mkardous-silabs approved these changes on 2025-04-17
mkardous-silabs26 days ago

With the nit of the valid boolean check

Conversation is marked as resolved
Show resolved
src/app/clusters/closure-dimension-server/closure-dimension-cluster-logic.cpp
60 if (currentState.latch.HasValue())
6161 {
6262 VerifyOrReturnError(mConformance.HasFeature(Feature::kMotionLatching), CHIP_ERROR_UNSUPPORTED_CHIP_FEATURE);
63 VerifyOrReturnError(EnsureKnownEnumValue(currentState.latching.Value()) != LatchingEnum::kUnknownEnumValue,
63
 VerifyOrReturnError(currentState.latch.Value() == true || currentState.latch.Value() == false,
mkardous-silabs26 days ago

I think we can remove this check. Since the type is a Nullable, we can't have an "invalid" boolean value here.

sabollim-silabs26 days ago

removed check

Conversation is marked as resolved
Show resolved
src/app/clusters/closure-dimension-server/closure-dimension-cluster-logic.cpp
9595 if (target.latch.HasValue())
9696 {
9797 VerifyOrReturnError(mConformance.HasFeature(Feature::kMotionLatching), CHIP_ERROR_UNSUPPORTED_CHIP_FEATURE);
98 VerifyOrReturnError(EnsureKnownEnumValue(target.latch.Value()) != TargetLatchEnum::kUnknownEnumValue,
98
 VerifyOrReturnError(target.latch.Value() == true || target.latch.Value() == false,
mkardous-silabs26 days ago

Same comment here.

sabollim-silabs26 days ago

removed check

Conversation is marked as resolved
Show resolved
src/app/clusters/closure-dimension-server/closure-dimension-cluster-logic.cpp
430430 if (latch.HasValue())
431431 {
432 VerifyOrReturnError(latch.Value() != TargetLatchEnum::kUnknownEnumValue, Status::ConstraintError);
432
 VerifyOrReturnError(latch.Value() == true || latch.Value() == false, Status::ConstraintError);
mkardous-silabs26 days ago

same comment

sabollim-silabs26 days ago

removed check

mkardous-silabs mkardous-silabs marked this pull request as ready for review 26 days ago
pullapprove pullapprove added review - pending
mkardous-silabs mkardous-silabs changed the title [Closures] [WIP] Update Closure dimension cluster as per latest specification [Closures] Update Closure dimension cluster as per latest specification 26 days ago
satyanaag-silabs Removing constrain check for boolean
09e1fd8c
restyled-commits Restyled by clang-format
7f3f273e
restyled-commits Restyled by prettier-json
4a396c57
mkardous-silabs mkardous-silabs added skip-protocol-compatibility
github-actions
github-actions26 days ago

PR #38424: Size comparison from 88bff31 to 4a396c5

Full report (3 builds for cc32xx, stm32)
platform target config section 88bff31 4a396c5 change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 542378 542378 0 0.0
RAM 205144 205144 0 0.0
lock CC3235SF_LAUNCHXL FLASH 576366 576366 0 0.0
RAM 205392 205392 0 0.0
stm32 light STM32WB5MM-DK FLASH 462928 462928 0 0.0
RAM 141488 141488 0 0.0
andy31415
andy31415 commented on 2025-04-17
Conversation is marked as resolved
Show resolved
src/app/zap-templates/zcl/data-model/chip/closure-dimension-cluster.xml
1919Source: src/app_clusters/ClosureDimension.adoc
2020Parameters: in-progress
21Git: 0.7-summer-2025-513-g8ca88d0f5
21
Git:
andy3141526 days ago

why is Git empty here?

sabollim-silabs25 days ago

Not sure why it was missed in the first generation.
removed the entire local spec repo and pulled a fresh repo and regenerated the file. now the git is added.

andy31415
andy31415 approved these changes on 2025-04-17
pullapprove pullapprove removed review - pending
pullapprove pullapprove added review - approved
satyanaag-silabs Add missing Git SHA in XML
3b603e25
satyanaag-silabs Removing old struct files
91c72b3b
mergify mergify merged ff5490ab into master 24 days ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
darwin controller app review - approved skip-protocol-compatibility
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum