benchmark
43851fb1 - Fix get_top() to return the base level event of the stack, not the most recently started event (#146649)

Commit
352 days ago
Fix get_top() to return the base level event of the stack, not the most recently started event (#146649) Summary: `get_top()` is really confusing when talking about a stack, because it can mean the most recently started event on the stack or the toplevel event in perfetto(which displays the stack upside down). Rename to `get_outermost` and fix the bug associated with it, so that it returns the correct value out of the stack. Running nanogpt now puts `guard_latency_us` correctly in the `dynamo` event: ``` tlp python benchmarks/dynamo/torchbench.py --backend inductor --device cuda --only nanogpt --amp --cold-start-latency --print-compilation-time --training --performance 2>&1 --dynamic-shapes | tee out.log ``` <img width="1281" alt="image" src="https://github.com/user-attachments/assets/4eeb371a-4d81-415a-acc4-7d303a4b2a93" /> X-link: https://github.com/pytorch/pytorch/pull/146649 Approved by: https://github.com/masnesral, https://github.com/anijain2305 Reviewed By: atalman Differential Revision: D69319924 fbshipit-source-id: a451463c786fe54113f953a7dfc5a4938cc9dddf
Author
Parents
Loading