benchmark
7bd07ecc - Guard DistillGPT2 fallback_random override to ROCm only (#190306)

Commit
88 days ago
Guard DistillGPT2 fallback_random override to ROCm only (#190306) Summary: # Summary https://github.com/pytorch/pytorch/issues/188835 flagged an A100 `DistillGPT2` AMP training accuracy failure. We bisected this issue to https://github.com/pytorch/pytorch/pull/186623/changes as the first failing commit. That commit attempts to fix accuracy error on ROCm/gfx942 by disabling `inductor_config.fallback_random`. This was only validated on gfx942, but on A100 it causes accuracy regression for this benchmark In this PR we guard the change to ROCm only and also remove the change from https://github.com/pytorch/pytorch/pull/188750 which was added to temporarily patch the issue Fixes https://github.com/pytorch/pytorch/issues/188835 # Validation Validated this change on both A100 and MI300x and confirmed the accuracy failure goes away. CI also shows the failing test is fixed https://github.com/pytorch/pytorch/actions/runs/29646406986/job/88107424644?pr=190306 A100/sm80, PyTorch `2.14.0.dev20260625+cu130` (`8dad44fdd9595ad80658b0ea49e3f322c978b139`), Triton source `3.7.1+gitf797708c`: ```bash python pytorch-src/benchmarks/dynamo/huggingface.py \ --accuracy --training --amp --inductor --device cuda \ --warm-start-latency --only DistillGPT2 \ --output /data/users/warrdeng/triton-pin/investigation_188835/a100_distillgpt2_guard.csv python pytorch-src/benchmarks/dynamo/check_accuracy.py \ --actual /data/users/warrdeng/triton-pin/investigation_188835/a100_distillgpt2_guard.csv \ --expected pytorch-src/benchmarks/dynamo/ci_expected_accuracy/inductor_huggingface_training.csv ``` Result: ```text cuda,DistillGPT2,1,pass,540,5,8,5,0,0,0,11.792233 DistillGPT2 PASS ``` Bisect evidence: ```text bc977b3d830f6838a460d16e4638e83904d63f9d: pass 63aad77ebd19313e1cf0df82bb554dbf65b3430e: fail_accuracy ``` Triton boundary evidence: ```text f797708c0626e5f9840ca5b0a98790e2c7cb09ad: STATUS FAIL 483327f0336aac7feb02a0eed45c2a6e2207ca00: STATUS FAIL ``` X-link: https://github.com/pytorch/pytorch/pull/190306 Approved by: https://github.com/frgossen Reviewed By: georgehong Differential Revision: D112963400 fbshipit-source-id: 1d1af4405b0b6edf72b9dc307bba018e8ed466e7
Author
Committer
Parents
Loading