fix: make TestPredictionPathUploadIterator deterministic (#2631)
* fix: make TestPredictionPathUploadIterator deterministic
This test was flaky in CI because it assumed webhooks would arrive in
strict chronological order with specific statuses at specific indices.
However, webhooks are delivered asynchronously and can arrive out of
order, especially in CI environments with varying performance.
The test would fail with:
Expected: "processing"
Actual: "succeeded"
This happened when the prediction completed faster than expected and
the "succeeded" webhook arrived before some "processing" webhooks.
Changes:
- Collect all webhooks until the final "succeeded" webhook arrives
- Validate the collected set of webhooks rather than assuming order
- Check for presence of expected states (initial processing, outputs)
rather than asserting on specific indices
- Make upload validation order-independent by collecting all uploads
first, then verifying their contents exist
- Remove unused strconv import
The test now passes consistently across multiple runs and different
environments.
* chore: try to debug test flakiness
Signed-off-by: Mark Phelps <mphelps@cloudflare.com>
* chore: dont use quiet in IT harness
Signed-off-by: Mark Phelps <mphelps@cloudflare.com>
---------
Signed-off-by: Mark Phelps <mphelps@cloudflare.com>
Co-authored-by: Mark Phelps <mphelps@cloudflare.com>
