pytorch

00f3790a - Using LoadLibraryEx and LOAD_LIBRARY_SEARCH_* flag for loading DLLs o… (#37763)

Using LoadLibraryEx and LOAD_LIBRARY_SEARCH_* flag for loading DLLs o… (#37763) Summary: …n Windows Without this PR, the OS try to find the DLL in the following directories. - The directory from which the application loaded. - The system directory. Use the GetSystemDirectory function to get the path of this directory. - The 16-bit system directory. There is no function that obtains the path of this directory, but it is searched. - The Windows directory. Use the GetWindowsDirectory function to get the path of this directory. - The current directory. - The directories that are listed in the PATH environment variable. Note that this does not include the per-application path specified by the App Paths registry key. The App Paths key is not used when computing the DLL search path. If we use LoadLibraryEx with LOAD_LIBRARY_SEARCH_* flags, the directories are searched in the following order. - The directory that contains the DLL (LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR). This directory is searched only for dependencies of the DLL to be loaded. - The application directory (LOAD_LIBRARY_SEARCH_APPLICATION_DIR). - Paths explicitly added to the application search path with the AddDllDirectory function (LOAD_LIBRARY_SEARCH_USER_DIRS) or the SetDllDirectory function. If more than one path has been added, the order in which the paths are searched is unspecified. - The System32 directory (LOAD_LIBRARY_SEARCH_SYSTEM32). Advantages: 1. The directory that contains the DLL comes first and it's desirable for us, because the dependencies in `lib` should always be preferred. 2. The system directory is considered in the last place. According to some of the bug reports, the DLL load failure are caused by loading the conflicting ones in systemroot. Neural: 1. The directories in `PATH` are not considered. Similar things happen as described in the previous point. So it may be beneficial for normal users. However, it may cause failures if there are some new dependencies if built from source. (Resolved by making the fallback to `LoadLibraryW` if error code is `126`) Disadvantages: 1. LoadLibraryEx with LOAD_LIBRARY_SEARCH_* flags is only available for Win7/2008 R2 + KB2533623 and up. (Resolved by making the fallback to `LoadLibraryW` if it is not supported) 2. Failure during the call of `LoadLibraryEx` will lead to the OS to pop up a modal dialog, which can block the process if user is using a CLI-only interface. This can be switched off by calling `SetErrorMode`. (Resolved by calling `SetErrorMode`) Pull Request resolved: https://github.com/pytorch/pytorch/pull/37763 Test Plan: Test some common cases (in a new repo maybe) including 1. Python 3.6/3.7/3.8, conda python, conda install 2. Python 3.6/3.7/3.8, conda python, pip install 3. Python 3.6/3.7/3.8, official python, pip install Plus some corner cases like 1. Conflicting DLLs in systemroot or `PATH` 2. Remove some local dependencies and use global ones References: 1. https://docs.microsoft.com/en-us/windows/win32/api/errhandlingapi/nf-errhandlingapi-seterrormode 2. https://docs.microsoft.com/en-us/windows/win32/api/libloaderapi/nf-libloaderapi-loadlibraryexa 3. https://docs.microsoft.com/en-us/windows/win32/dlls/dynamic-link-library-search-order#standard-search-order-for-desktop-applications What do you think, malfet ezyang ? Differential Revision: D21496081 Pulled By: malfet fbshipit-source-id: aa5e528e5134326b00ac98982f4db4b4bbb47a44