pytorch
07824730 - fix minor issues for ATen/ROCm (#71925)

Commit
2 years ago
fix minor issues for ATen/ROCm (#71925) Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/71925 This patch fixes a few minor issues and introduces a few changes that are found in enabling ROCm compilation for ATen. 1. Minor type-related changes in `ATen/miopen/*` This is to suppress compiler warnings. 2. [EXCLUDED] Hipify `ATen/naitve/miopen/*.cpp` `ATen/native/miopen/*.cpp` includes "cuda/CUDAConfig.h", which should be `hip/HIPConfig.h` (though compilation succeeds without this change since currently `CUDAConfig.h` = `HIPConfig.h`). 3. Update `gen.py` to include `hip/EmptyTensor.h` instead of `cuda/EmptyTensor.h` for HIP compilation `RegisterCUDA.cpp` (for HIP) should include `hip/EmptyTensor.h` (though compilation succeeds without this change since currently `cuda/EmptyTensor.h` does not contain CUDA-specific logic). 4. Exclude the `USE_DIRECT_NVRTC` code when `USE_ROCM=0`. Note that `USE_DIRECT_NVRTC` is always undefined for OSS compilation. It seems that this flag exists only for an internal purpose. 5. [EXCLUDED] Exclude `frexp()` for ROCm <= 3.10 a newer ROCm (i.e., officially supported ROCm versions) has `frexp()`, but an old ROCm (e.g., ROCm <= 3.10) doesn't. This preprocessor branch avoids compilation error for old ROCm (though such an old ROCm is not officially supported). 6. Change an include path from `aten/src/ATen/` to `ATen/` in `SharedReduceOps.h` This is, as far as I checked, the only place that includes `Aten` from `aten/src`. This change unifies the include format. Test Plan: CI (including GitHub CI for ROCm) Reviewed By: xw285cornell Differential Revision: D33441758 fbshipit-source-id: 0853806c60de050d329b5ddddb8d51948f8f2788 (cherry picked from commit c2b8c16308037df5b76a89603203ae26d0f4580b)
Committer
Parents
Loading