pytorch

0c8f1662 - [Caffe2] Rework CAFFE_ENFORCE_THAT (#53303)

[Caffe2] Rework CAFFE_ENFORCE_THAT (#53303) Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/53303 The old code did a heap allocation unnecessarily and was a little convoluted. I think that it was structured that way to avoid double-evaluating arguments; I just forced them to be evaluated once as though they were passed to a function by binding const references to them. ghstack-source-id: 123918262 Test Plan: 1) `buck run mode/opt-clang //caffe2/caffe2/fb/tests:logging_bench` Before: ``` ============================================================================ caffe2/caffe2/fb/tests/logging_bench.cpp relative time/iter iters/s ============================================================================ glog_CHECK 2.01ns 498.63M caffe2_ENFORCE_GE 50.00% 4.01ns 249.31M glog_CHECK_GE 17.39% 11.53ns 86.73M fbcode_ENFORCE 100.00% 2.01ns 498.65M caffe2_ENFORCE 100.00% 2.01ns 498.63M caffe2_ENFORCE_THAT 50.00% 4.01ns 249.33M ============================================================================ ``` After: ``` ============================================================================ caffe2/caffe2/fb/tests/logging_bench.cpp relative time/iter iters/s ============================================================================ glog_CHECK 2.01ns 498.63M caffe2_ENFORCE_GE 97.44% 2.06ns 485.88M glog_CHECK_GE 17.39% 11.53ns 86.73M fbcode_ENFORCE 100.00% 2.01ns 498.65M caffe2_ENFORCE 100.00% 2.01ns 498.65M caffe2_ENFORCE_THAT 97.28% 2.06ns 485.06M ============================================================================ ``` Looks like about a 1.94x speedup! 2) Inspect generated assembly for logging_bench.cpp before & after by: ``` $ compile-commands caffe2/caffe2/fb/tests/logging_bench.cpp -f "mode/opt-clang" $ jq -r '.[0].arguments | sh' < compile_commands.json | sed -e "s/'-c'/'-S'/g" | sed -E -e "s/'-g[12]'/'-g0'/g" > out.sh $ sh out.sh ``` Then diff logging_bench.s as you like. Before: P255408666 After: P277883307 Net about 1500 lines deleted from the assembly. We can see that the happy path (which the benchmark tests) no longer contains string creation. Reviewed By: dzhulgakov Differential Revision: D26829714 fbshipit-source-id: 6e11f8ea29292ae3d9f2cc89d08afcb06f7d39c9