pytorch

15435325 - Configure PyTorch Testing ArgumentParser Instance To Avoid Unnecessary Conflicts with System Args (#85616)

Configure PyTorch Testing ArgumentParser Instance To Avoid Unnecessary Conflicts with System Args (#85616) Fixes #85615 Currently, internal test discovery instantiates an `ArgumentParser` and adds numerous arguments to the internal parser: https://github.com/pytorch/pytorch/blob/f0570354dda37c03c63377ada1ec889cf82ae9f6/torch/testing/_internal/common_utils.py#L491-L500 ... In this context, `argparse` will load [system args](https://github.com/python/cpython/blob/b494f5935c92951e75597bfe1c8b1f3112fec270/Lib/argparse.py#L1826-L1829) from any external scripts invoking PyTorch testing (e.g. `vscode`). The default behavior of `argparse` is to [allow abbreviations](https://github.com/python/cpython/blob/b494f5935c92951e75597bfe1c8b1f3112fec270/Lib/argparse.py#L2243-L2251) of arguments, but when an `ArgumentParser` instance has many arguments and may be invoked in the context of potentially conflicting system args, the `ArgumentParser` should reduce the potential for conflicts by being instantiated with `allow_abbrev` set to `False`. With the current default configuration, some abbreviations of the `ArgumentParser` long options conflict with system args used by `vscode` to invoke PyTorch test execution: ```bash python ~/.vscode-server/extensions/ms-python.python-2022.14.0/pythonFiles/get_output_via_markers.py \ ~/.vscode-server/extensions/ms-python.python-2022.14.0/pythonFiles/visualstudio_py_testlauncher.py \ --us=./test --up=test_cuda.py --uvInt=2 -ttest_cuda.TestCuda.test_memory_allocation \ --testFile=./test/test_cuda.py >>>PYTHON-EXEC-OUTPUT ... visualstudio_py_testlauncher.py: error: argument --use-pytest: ignored explicit argument './test' ``` The full relevant stack: ``` pytorch/test/jit/test_cuda.py, line 11, in <module>\n from torch.testing._internal.jit_utils import JitTestCase\n'\ pytorch/torch/testing/_internal/jit_utils.py, line 18, in <module>\n from torch.testing._internal.common_utils import IS_WINDOWS, \\\n' pytorch/torch/testing/_internal/common_utils.py, line 518, in <module>\n args, remaining = parser.parse_known_args()\n' argparse.py, line 1853, in parse_known_args\n namespace, args = self._parse_known_args(args, namespace)\n' argparse.py, line 2062, in _parse_known_args\n start_index = consume_optional(start_index)\n' argparse.py, line 1983, in consume_optional\n msg = _(\'ignored explicit argument %r\')\n' ``` The `argparse` [condition](https://github.com/python/cpython/blob/b494f5935c92951e75597bfe1c8b1f3112fec270/Lib/argparse.py#L2250) that generates the error in this case: ```python print(option_string) --use-pytest print(option_prefix) --us option_string.startswith(option_prefix) True ``` It'd be nice if `vscode` didn't use two-letter options :facepalm: but PyTorch testing shouldn't depend on such good behavior by invoking wrappers IMHO. I haven't seen any current dependency on the abbreviated internal PyTorch `ArgumentParser` options so this change should only extend the usability of the (always improving!) PyTorch testing modules. This simple PR avoids these conflicting options by instantiating the `ArgumentParser` with `allow_abbrev=False` Thanks to everyone in the community for their continued contributions to this incredibly valuable framework. Pull Request resolved: https://github.com/pytorch/pytorch/pull/85616 Approved by: https://github.com/clee2000