pytorch
1e275bc1 - Show Flake8 errors in GitHub CI again (#46990)

Commit
4 years ago
Show Flake8 errors in GitHub CI again (#46990) Summary: Fixes https://github.com/pytorch/pytorch/issues/46985. Can someone comment on whether the "Run flake8" step should fail if `flake8` produces errors? This PR makes sure the errors are still shown, but [the job linked from the issue](https://github.com/pytorch/pytorch/runs/1320258832) also shows that the failure of that step seems to have caused the "Add annotations" step not to run. Is this what we want, or should I instead revert back to the `--exit-zero` behavior (in this case by just removing the `-o pipefail` from this PR) that we had before https://github.com/pytorch/pytorch/issues/46740? And if the latter, then (how) should I modify this `flake8-py3` job to make sure it fails when `flake8` fails (assuming it didn't already do that?) Pull Request resolved: https://github.com/pytorch/pytorch/pull/46990 Reviewed By: VitalyFedyunin Differential Revision: D24593573 Pulled By: samestep fbshipit-source-id: 361392846de9fadda1c87d2046cf8d26861524ca
Author
Parents
Loading