pytorch
2291960d - Back out "record_function: update to use custom_class API" (#76253)

Commit
2 years ago
Back out "record_function: update to use custom_class API" (#76253) Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/76253 We're observing large QPS regression on the original PR https://github.com/pytorch/pytorch/pull/72302. For the training job we had, it regressed from 720k QPS to 450k QPS (see the test plan in FB internal). We suspect this is because the api was changed from `_record_function_enter` to `_record_function_enter_new`, and we're running experiments to confirm that. Will add more details when the runs in the test plan has finished. For now, it's better to revert the diff to unblock internal usecases and we can think about how to reland this diff later. Original commit changeset: dc9939f1fa6d Original Phabricator Diff: D35257354 Test Plan: on trunk: f338665947 with this diff: f338502850 Reviewed By: malfet, robieta Differential Revision: D35853300 fbshipit-source-id: dd38042aeacb848f66756491a4c849c7c652a0e1
Author
Committer
Parents
Loading