pytorch
29ecb9f9 - Don't check stride by default (#60637)

Commit
3 years ago
Don't check stride by default (#60637) Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/60637 We now have ~three out of three~ four out of four datapoints that `check_stride` will be `partial`'ed to `False`: - `torch` test suite: https://github.com/pytorch/pytorch/pull/58981#discussion_r639514081 - `torchvision` test suite: https://github.com/pytorch/pytorch/issues/56544#issuecomment-845352605 - `kornia`: https://github.com/kornia/kornia/blob/9041c42b410e6a4bbb664c7134a120be80aa2265/test/utils.py#L25 - `torch.fft`: https://github.com/pytorch/pytorch/pull/60304#pullrequestreview-687882323 Given that the strides in most cases are in implementation detail, IMO we should change the default to `False`. In cases were matching strides is a requirement for closeness / equality it can always set to `True` manually. Test Plan: Imported from OSS Reviewed By: ngimel Differential Revision: D29556355 Pulled By: mruberry fbshipit-source-id: 0029a44280d8f4369fbdb537dce3202eeee4b1d9
Author
Parents
Loading