pytorch
2cac92f4 - [SR] Migrate sigrid_transforms_torch_bind to new FuseListUnpack (#67163)

Commit
3 years ago
[SR] Migrate sigrid_transforms_torch_bind to new FuseListUnpack (#67163) Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/67163 Migrated both the variadic and non-variadic versions. This diff is part of the effort to migrate all ops used in `FuseListUnpack` to `FuseListUnpackV2`. The original version of `FuseListUnpack` is problematic for a few reasons: * You have to complicate the op implementation with an `is_fused` check, resulting in messier code. It is easier to reason about two ops, fused (out variant) and unfused (native). * The original version of `FuseListUnpack` is buggy. It assumes that the `ListUnpack` node occurs immediately after the fusion candidate, which is not necessarily true. Test Plan: Unit tests: `buck test caffe2/benchmarks/static_runtime/...` **Accuracy Test** Done at the top of this diff stack. **Performance** Everything seems to be about the same plus or minus some noise. * Baseline (D31947382 with some errors correct locally, the version of the op here is fused and variadic): P464964343 * This diff, fused_variadic: P464960645 * Variadic transformation disabled, fused (caught and fixed a schema error here): P464961561 * List unpack fusion disabled, variadic: P464962661 * Both variadic and fusion passes disabled: P464963342 The predictions match with the JIT interpreter for all ops. Reviewed By: hlu1 Differential Revision: D31887300 fbshipit-source-id: 25a7b4e35eed21ca8b2c98297513425cf17f461a
Author
Mike Iovine
Parents
Loading