dictPop: dereference dict.find() iterator before calling dict.erase() (#25056)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/25056
For some combinations of key and entry ordering (and only on an OSX
build) dict.pop() would return a value other than the popped one,
failing test_pop in test_jit.py. Caused by erase() mutating the
iterator returned from find(), fixed by dereferencing it first.
Test Plan: Imported from OSS
Differential Revision: D16975020
Pulled By: bhosmer
fbshipit-source-id: ce84e9aed6b90010121c0ef5d6c9ed8d2d1356b8
