pytorch
300f7777 - [Vulkan] Use EXPECT_EQ instead of ASSERT_TRUE in vulkan_api_test querypool_flushed_shader_log (#91259)

Commit
2 years ago
[Vulkan] Use EXPECT_EQ instead of ASSERT_TRUE in vulkan_api_test querypool_flushed_shader_log (#91259) Summary: After this change, if the querypool_flushed_shader_log test fails: 1) The test continues after the first failure and checks all three (Because ASSERT was changed to EXPECT) 2) The op names which are compared to vulkan.add, vulkan.sub, and vulkan.mul are shown (rather than not showing what the wrong op name was) (Because we use ..._EQ(a, b) instead of just checking ...(a == b)) This change makes it easier to debug future failures to querypool_flushed_shader_log (it helped me when one of my diffs broke the test) Test Plan: Vulkan API Test - https://www.internalfb.com/intern/aibench/details/959371570734292 Reviewed By: SS-JIA Differential Revision: D42186371 Pull Request resolved: https://github.com/pytorch/pytorch/pull/91259 Approved by: https://github.com/SS-JIA
Author
Committer
Parents
Loading