pytorch
3e218dbd - [PyTorch] Capture function args from schema by reference (#65951)

Commit
4 years ago
[PyTorch] Capture function args from schema by reference (#65951) Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/65951 Profiling shows that we do a bunch of heap allocations to copy Argument structs in append_operator. Capturing by reference here should be safe as long as the schema objects args is from outlive the operator function. IMPORTANT: Reviewers (or automated tests if we're lucky) need to confirm that the above is true or we're going to have fun use-after-free bugs. ghstack-source-id: 142065422 Test Plan: AIBench run for speech model on MilanBoard control: https://www.internalfb.com/intern/aibench/details/485570882988661 (mean 906 ms) test: https://our.intern.facebook.com/intern/aibench/details/620835625995669 (mean 818 ms) So almost a 10% improvement in the wall time metric? Reviewed By: iseeyuan Differential Revision: D31319988 fbshipit-source-id: 7da56357420df500df344f49007e070ebb1bc581
Author
Parents
Loading