pytorch
428cb3a8 - distinguish mutability of untyped StorageImpl::data() member (#97647)

Commit
2 years ago
distinguish mutability of untyped StorageImpl::data() member (#97647) To implement the warning when transitioning reshape to copy-on-write storage, we want to be able to detect a write to one view family following by a read or a write to another one that shares the same copy-on-write storage. Because we have historically not been strict about the mutability of our data pointers, any warning we have would likely be far too aggressive. Therefore, this is the first PR in a long series to ensure a strict distinction between mutable and const data accessors in TensorBase, TensorImpl, Storage, and StorageImpl. The rough plan is to give the mutable accessor a new name that is explicit about mutation, this will also force us to rewrite any code that really needs a mutation. Differential Revision: [D44409928](https://our.internmc.facebook.com/intern/diff/D44409928/) Pull Request resolved: https://github.com/pytorch/pytorch/pull/97647 Approved by: https://github.com/ezyang
Author
mikey dagitses
Committer
Parents
Loading