pytorch

4299faa1 - Fix invalid function cast warnings that show up with GCC 8/9 (#25483)

Fix invalid function cast warnings that show up with GCC 8/9 (#25483) Summary: Fixes ~5000 lines of warnings like: ``` In file included from ../aten/src/TH/TH.h:4, from ../torch/csrc/Storage.cpp:11: ../torch/csrc/Storage.h:6:39: warning: cast between incompatible function types from ‘PyObject* (*)(THPStorage*)’ {aka ‘_object* (*)(THPStorage*)’} to ‘getter’ {aka ‘_object* (*)(_object*, void*)’} [-Wcast-function-type] 6 | #define THPStorage_(NAME) TH_CONCAT_4(THP,Real,Storage_,NAME) | ^~~ caffe2/aten/src/TH/THGeneral.h:154:37: note: in definition of macro ‘TH_CONCAT_4_EXPAND’ 154 | #define TH_CONCAT_4_EXPAND(x,y,z,w) x ## y ## z ## w | ^ ../torch/csrc/Storage.h:6:27: note: in expansion of macro ‘TH_CONCAT_4’ 6 | #define THPStorage_(NAME) TH_CONCAT_4(THP,Real,Storage_,NAME) | ^~~~~~~~~~~ ../torch/csrc/generic/Storage.cpp:299:22: note: in expansion of macro ‘THPStorage_’ 299 | {"device", (getter)THPStorage_(device), nullptr, nullptr, nullptr}, | ^~~~~~~~~~~ ../torch/csrc/Storage.h:6:39: warning: cast between incompatible function types from ‘PyObject* (*)(THPStorage*)’ {aka ‘_object* (*)(THPStorage*)’} to ‘getter’ {aka ‘_object* (*)(_object*, void*)’} [-Wcast-function-type] 6 | #define THPStorage_(NAME) TH_CONCAT_4(THP,Real,Storage_,NAME) | ^~~ caffe2/aten/src/TH/THGeneral.h:154:37: note: in definition of macro ‘TH_CONCAT_4_EXPAND’ 154 | #define TH_CONCAT_4_EXPAND(x,y,z,w) x ## y ## z ## w | ^ ../torch/csrc/Storage.h:6:27: note: in expansion of macro ‘TH_CONCAT_4’ 6 | #define THPStorage_(NAME) TH_CONCAT_4(THP,Real,Storage_,NAME) | ^~~~~~~~~~~ ``` This issue and the fix is very similar to how CPython fixed it, see https://bugs.python.org/issue33012. There's still more of these warnings left, but this fixes the majority of them. Pull Request resolved: https://github.com/pytorch/pytorch/pull/25483 Differential Revision: D17149824 Pulled By: ezyang fbshipit-source-id: 353560a4f76070fa7482608e9532b60205d16798