pytorch
434eb16d - Correctly restore pybind11 error_already_set (#93238)

Commit
2 years ago
Correctly restore pybind11 error_already_set (#93238) We would handle py::error_already_set correctly from pybind11 bindings, but not from our regular TH bindings, which meant that anything from an inner pybind11 function call was getting unconditionally transformed into a RuntimeError. Not too many cases where we do this, but PySymNodeImpl was one of them. To test this, I need to raise a non-RuntimeError from a function which is invoked from pybind11 and then propagated to a non-pybind11 call site. I introduce GuardOnDataDependentSymNode for expressly this purpose (this is how I discovered the bug anyway.) Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: https://github.com/pytorch/pytorch/pull/93238 Approved by: https://github.com/Skylion007, https://github.com/albanD
Author
Committer
Parents
Loading