pytorch
49dbe179 - [kineto] Deprecate ClientTraceActivity and merge it with GenericTraceActivity (#56743)

Commit
3 years ago
[kineto] Deprecate ClientTraceActivity and merge it with GenericTraceActivity (#56743) Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/56743 Pull Request resolved: https://github.com/pytorch/kineto/pull/184 as part of the migration to ClientTraceActivity -> GenericTraceActivity, now that all CTA mirrors GTA's data structure, we can safely swap out the symbol name. Test Plan: - `buck build kineto` - sandcastle to catch any other breakage in depdendees Took before and after of `fastrnns` bench `buck run mode/opt //caffe2/benchmarks/fastrnns:bench -- --cnns resnet50 --group cnns --nloops 1000` Before https://fburl.com/perfdoctor/9n0izgji {F611729029} After https://fburl.com/perfdoctor/h9d9tlmp {F611725475} Sample ParamComms traces https://www.internalfb.com/intern/perfdoctor/trace_view?filepath=tree%2Ftraces%2Fdynocli%2F0%2F1619503816%2F127.0.0.1%2Flibkineto_activities_4003656.json.gz&bucket=gpu_traces https://www.internalfb.com/intern/perfdoctor/trace_view?filepath=tree%2Ftraces%2Fdynocli%2F0%2F1619503816%2F127.0.0.1%2Flibkineto_activities_4003657.json.gz&bucket=gpu_traces https://www.internalfb.com/intern/perfdoctor/trace_view?filepath=tree%2Ftraces%2Fdynocli%2F0%2F1619503816%2F127.0.0.1%2Flibkineto_activities_4003658.json.gz&bucket=gpu_traces Reviewed By: gdankel Differential Revision: D27353973 fbshipit-source-id: 7012c6524c3c75079029ac290c1dd722ac187ec5
Author
Parents
Loading