pytorch

4befe450 - [FX] Add one option to maintain the FX graph execution order after splitting_module (#85188)

[FX] Add one option to maintain the FX graph execution order after splitting_module (#85188) Summary: {F770932209} Given the original execution order and the node dependency relationship (note that the same dependency order could generate multiple execution order, which refers to “Topological Order”), after reunion, we could find the new execution order of the new GraphModule is different from the original one which is not what we want. For example, let’s assume that NewLeaf_1 is EmbeddingLookup (Calling EmbeddingLookup is awaitable, we will keep executing the following nodes rather than waiting for the result until we have to know the lookup result), NewLeaf_4 is the node where we HAVE to get the lookup result to interact with the NewLeaf_3. So NewLeaf_1 will launch a lookup kernel and all2all communication stream to distribute the result to all ranks. In the meantime, we want to keep executing NewLeaf_2 and NewLeaf_3 to avoid meaningless waiting. However, given the new execution order, we have to wait for the lookup kernel and all2all communication to be finished since the next node NewLeaf_4 needs the result, until then we can execute NewLeaf_2, etc. It cannot leverage the advantage of parallel computation and communication stream and will hurt the QPS a lot. So while constructing the GraphModule, we have to change from the topological order to the original order Test Plan: Unit test Not sure how to add tests in FX as there's no TARGETS, so I added in the TorchRec folder Differential Revision: D39567314 Pull Request resolved: https://github.com/pytorch/pytorch/pull/85188 Approved by: https://github.com/SherlockNoMad