pytorch
5105a8d3 - Enable Kineto in OSS builds by fixing build condition (resubmit) (#93033)

Commit
3 years ago
Enable Kineto in OSS builds by fixing build condition (resubmit) (#93033) Resubmit of https://github.com/pytorch/pytorch/pull/89174 . I think I fixed underlying issues back then, but only CI would tell. Context: This PR enables Kineto on OSS builds because of how the flags were misconfigured before. I think generally having global observer in OSS is nice. There's some work to release on demand profiling with dynolog, and right now its build instructions start with "go change pytorch's CMake": https://github.com/facebookincubator/dynolog/blob/main/docs/pytorch_profiler.md#pytorch-setup The previous PR was reverted because of the bug in Kineto that got fixed in https://github.com/pytorch/kineto/pull/696 (and the submodule was updated since) Pull Request resolved: https://github.com/pytorch/pytorch/pull/93033 Approved by: https://github.com/kimishpatel
Author
Committer
Parents
Loading