pytorch
57d1df07 - [ONNX] Support inplace operations on inplace indexing (#52063) (#53306)

Commit
3 years ago
[ONNX] Support inplace operations on inplace indexing (#52063) (#53306) Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/53306 * [ONNX] Fix for sequence of mutations in blocks (#51577) Fixes consecutive mutations in a tensor inside blocks. Also, support append and pop in blocks. * Support inplace operations + indexing * Clean up old pass for remove mutations * Add loop test * Fixes for set attr in loops * Removing the new jit API flag * [ONNX] Redesign onnx pass to enable shape type dependent pattern conversion - cont (#51795) With the introduction of ONNX shape inference, shape and type are inferred on the fly as operators get converted from ATen to ONNX when running symbolic function. This resolves the shape/type requirement for the symbolic functions. The pre-onnx passes however, can not be supported by shape inference, since at that stage the operators in the graph are still ATen operators. This PR is to update the design of ONNX pass, to enable a mechanism of capturing subgraphs of ATen operators of certain patterns, and convert them later, when shape/type information of upstream operators are available. The new design will require pre-onnx passes that need shape/type to be written in two parts, encapsulation and conversion. The encapsulation part will find the nodes of patterns, like how pre-onnx passes were written previously. But instead of converting the nodes, it will encapsulate them into a sub-block of a new placeholder node. This part is called before onnx pass, so it runs before calling symbolic functions. The conversion part will be called inside the onnx pass. In onnx pass, run_symbolic_func will be called for each node in topological order. When it reaches the placeholder node, the conversion part will be invoked. It will convert the nodes inside the sub-block based on pattern. By that time, it will have shape/type of upstream operators available. After the conversion is complete, the placeholder node will be removed, and nodes inside its sub-block converted. Run_symbolic_func will be called for these nodes, and they will be converted from ATen operator to ONNX operator. This PR includes several other fixes, listed below. * ~~replace helper.cpp with onnx_utils.cpp for holding utility functions.~~ * fix EraseNumberTypes on Bool type, the code was outdated that back then Bool type doesn't exist. * ~~enable onnx shape inference in export with parameter/initializer data.~~ * other code clean ups. * fix insertion of identity nodes for loop opset 13 sequence output. ~~PR depends on #51603~~ * Fix after merge * clang * Fix clang * Fix clang * Fix warning message. * Fixes for non-model param attributes * Fix for caffe2 * Additional test * clang * Skip test for lower opsets * fix clang-tidy * Update init.cpp * Update remove_inplace_ops_for_onnx.cpp * Update remove_inplace_ops_for_onnx.cpp * Update remove_inplace_ops_for_onnx.cpp * Fix for clang formatting Test Plan: Imported from OSS Reviewed By: pbelevich, malfet Differential Revision: D26922416 Pulled By: SplitInfinity fbshipit-source-id: e7108620b39b6404c594910786c4d275fee59d84 Co-authored-by: Bowen Bao <bowbao@microsoft.com>
Author
Parents
Loading