pytorch
68a49322 - [MacOS] Explicitly use cmake from cloned conda environment (#92737)

Commit
1 year ago
[MacOS] Explicitly use cmake from cloned conda environment (#92737) My first attempt to fix `Library not loaded: @rpath/libzstd.1.dylib` issue on MacOS M1 in https://github.com/pytorch/pytorch/pull/91142 provides some additional logs about flaky error but doesn't fix the issue as I see some of them recently, for example * https://hud.pytorch.org/pytorch/pytorch/commit/e4d83d54a6214d8fa1a9063f0da65932b45b7207 Looking at the log, I can see that: * CMAKE_EXEC correctly points to `CMAKE_EXEC=/Users/ec2-user/runner/_work/_temp/conda_environment_3971491892/bin/cmake` * The library is there under the executable rpath ``` ls -la /Users/ec2-user/runner/_work/_temp/conda_environment_3971491892/bin/../lib ... 2023-01-20T23:22:03.9761370Z -rwxr-xr-x 2 ec2-user staff 737776 Apr 22 2022 libzstd.1.5.2.dylib 2023-01-20T23:22:03.9761630Z lrwxr-xr-x 1 ec2-user staff 19 Jan 20 22:47 libzstd.1.dylib -> libzstd.1.5.2.dylib ... ``` Then calling cmake after that suddenly uses the wrong cmake from miniconda package cache: ``` 2023-01-20T23:22:04.0636880Z + cmake .. 2023-01-20T23:22:04.1924790Z dyld[85763]: Library not loaded: @rpath/libzstd.1.dylib 2023-01-20T23:22:04.1925540Z Referenced from: /Users/ec2-user/runner/_work/_temp/miniconda/pkgs/cmake-3.22.1-hae769c0_0/bin/cmake ``` This is weird, so my second attempt will be more explicit and use the correct cmake executable in `CMAKE_EXEC`. May be something manipulates the global path in between making ` /Users/ec2-user/runner/_work/_temp/miniconda/pkgs/cmake-3.22.1-hae769c0_0/bin/cmake` comes first in the PATH Pull Request resolved: https://github.com/pytorch/pytorch/pull/92737 Approved by: https://github.com/ZainRizvi
Author
Committer
Parents
Loading