pytorch
6a403399 - [SPMD] Error out SPMD mode (#54454)

Commit
3 years ago
[SPMD] Error out SPMD mode (#54454) Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/54454 According to the pitch in https://github.com/pytorch/pytorch/issues/47012 1. Let DDP error out if `device_ids` contains multiple devices. 2. If device_ids is not specified, DDP will use the provided model (module argument in DDP constructor) as-is, regardless if the model is on one GPU or multiple GPUs or on CPU. 3. Remove the assertion that prevents SPMD in DDP `join()` method, because now SPMD is already forbidden by the constructor. Also remove the relevant unit test `test_ddp_uneven_inputs_replicated_error`. #Closes: https://github.com/pytorch/pytorch/issues/47012 ghstack-source-id: 125644392 Test Plan: buck test mode/dev-nosan caffe2/test/distributed:distributed_gloo_spawn -- test_cuda buck test mode/dev-nosan caffe2/test/distributed:distributed_gloo_spawn -- test_rnn buck test mode/dev-nosan caffe2/test/distributed:c10d -- test_nccl_backend_multi_device_ids_not_allowed buck test mode/dev-nosan caffe2/test/distributed:c10d -- test_nccl_backend_single_device_module_device_ids_None buck test mode/dev-nosan caffe2/test/distributed:c10d -- test_nccl_backend_multi_device_module_device_ids_None buck test mode/dev-nosan caffe2/test/distributed:c10d -- test_ddp_multi_device_module_config waitforbuildbot Reviewed By: pritamdamania87 Differential Revision: D27226092 fbshipit-source-id: 3ee1e4bc46e5e362fc82cf7a24b2fafb34fcf1b9
Author
Yi Wang
Parents
Loading