pytorch

6adbe044 - Added nearest-exact interpolation mode (#64501)

Added nearest-exact interpolation mode (#64501) Summary: Added "nearest-exact" interpolation mode to fix the issues: https://github.com/pytorch/pytorch/issues/34808 and https://github.com/pytorch/pytorch/issues/62237. Description: As we can not fix "nearest" mode without large impact on already trained model [it was suggested](https://github.com/pytorch/pytorch/pull/64501#pullrequestreview-749771815) to introduce new mode instead of fixing exising "nearest" mode. - New mode "nearest-exact" performs index computation for nearest interpolation to match scikit-image, pillow, TF2 and while "nearest" mode still match opencv INTER_NEAREST, which appears to be buggy, see https://ppwwyyxx.com/blog/2021/Where-are-Pixels/#Libraries. "nearest": ``` input_index_f32 = output_index * scale input_index = floor(input_index_f32) ``` "nearest-exact" ``` input_index_f32 = (output_index + 0.5) * scale - 0.5 input_index = round(input_index_f32) ``` Comparisions with other libs: https://gist.github.com/vfdev-5/a5bd5b1477b1c82a87a0f9e25c727664 PyTorch version | 1.9.0 "nearest" | this PR "nearest" | this PR "nearest-exact" ---|---|---|--- Resize option: | | OpenCV INTER_NEAREST result mismatches | 0 | 0 | 10 OpenCV INTER_NEAREST_EXACT result mismatches | 9 | 9 | 9 Scikit-Image result mismatches | 10 | 10 | 0 Pillow result mismatches | 10 | 10 | 7 TensorFlow result mismatches | 10 | 10 | 0 Rescale option: | | | size mismatches (https://github.com/pytorch/pytorch/issues/62396) | 10 | 10 | 10 OpenCV INTER_NEAREST result mismatches | 3 | 3| 5 OpenCV INTER_NEAREST_EXACT result mismatches | 3 | 3| 4 Scikit-Image result mismatches | 4 | 4 | 0 Scipy result mismatches | 4 | 4 | 0 TensorFlow: no such option | - | - Versions: ``` skimage: 0.19.0.dev0 opencv: 4.5.4-dev scipy: 1.7.2 Pillow: 8.4.0 TensorFlow: 2.7.0 ``` Implementations in other libs: - Pillow: - https://github.com/python-pillow/Pillow/blob/ee079ae67e7e24ec789d3cc7d180820a70d32fe6/src/libImaging/Geometry.c#L889-L899 - https://github.com/python-pillow/Pillow/blob/ee079ae67e7e24ec789d3cc7d180820a70d32fe6/src/libImaging/Geometry.c#L11 - `a[2] == 0` - Scikit-Image : - dev v0.19.0 uses scipy ndi.zoom: - https://github.com/scikit-image/scikit-image/blob/38fae50c3ffc19e78b3adc848eb9bd0916e13dc8/skimage/transform/_warps.py#L180-L188 - https://github.com/scipy/scipy/blob/47bb6febaa10658c72962b9615d5d5aa2513fa3a/scipy/ndimage/src/ni_interpolation.c#L775-L779 - https://github.com/scipy/scipy/blob/47bb6febaa10658c72962b9615d5d5aa2513fa3a/scipy/ndimage/src/ni_interpolation.c#L479 Additionally: - Updated upsampling tests cc ezyang gchanan albanD mruberry jbschlosser walterddr fmassa heitorschueroff ppwwyyxx Pull Request resolved: https://github.com/pytorch/pytorch/pull/64501 Reviewed By: anjali411 Differential Revision: D32361901 Pulled By: jbschlosser fbshipit-source-id: df906f4d25a2b2180e1942ffbab2cc14600aeed2