pytorch
76f29d53 - ns for fx: change matching to only match known types (#57186)

Commit
3 years ago
ns for fx: change matching to only match known types (#57186) Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/57186 Before this PR, we matched any pair of nodes with equal or related types. This PR changes the behavior to only match nodes whose type is in the allowlist (the relatedness mappings). This will prevent matching user defined modules, unless users add them to the mappings. This is motivated by a couple of things: 1. if user defined types are matched, it can break scriptability of the model with loggers attached. This happens whenever the user module has a return type of anything other than a Tensor or a tuple of Tensors. 2. we tried the past behavior on a couple of models, and it hasn't been useful. Test Plan: ``` python test/test_quantization.py TestFXGraphMatcher python test/test_quantization.py TestFXGraphMatcherModels python test/test_quantization.py TestFXNumericSuiteCoreAPIs python test/test_quantization.py TestFXNumericSuiteCoreAPIsModels ``` Imported from OSS Reviewed By: jerryzh168 Differential Revision: D28077981 fbshipit-source-id: 0a698e52b807cda47e6923310448a985b26eb362
Author
Parents
Loading