pytorch
7c72238e - Back out "Enable pickling model prepared with QAT qconfig" (#110392)

Commit
1 year ago
Back out "Enable pickling model prepared with QAT qconfig" (#110392) Summary: D49187352 caused our model conversion and loading of QAT checkpoint to be stuck with thrift time out. we are actively checking in final code and model for static quant HTP prod model, and encountered this breakage at head Thursday. Thrift timeout is a not failing, and because of that, it's hard to bisect and find this culprit. It is also hard to set up unit test, because the job simply time-out. Better test is needed to guard downstream model conversion against upstream changes. Our suspicion of why this diff broke us is that we create a lot of modules with qat (in a recursive manner) but our model is not a qat traceable module (it is a graph with many qat modules and floating point modules). With fuctools.partial as in the original diff, we will be caching modules in the memory and causing the memory of the machine to be taken up completely. Pull Request resolved: https://github.com/pytorch/pytorch/pull/110392 Approved by: https://github.com/junesg, https://github.com/jerryzh168
Author
Committer
Parents
Loading