pytorch
909694fd - Fix `nn.functional.max_poolNd` dispatch (for arg: `return_indices`) (#62544)

Commit
3 years ago
Fix `nn.functional.max_poolNd` dispatch (for arg: `return_indices`) (#62544) Summary: Please see https://github.com/pytorch/pytorch/issues/62545 for context. The order of `return_indices, ceil_mode` is different for `nn.functional.max_poolNd` functions to what seen with `torch.nn.MaxPoolNd` (modular form). While this should be resolved in the future, it was decided to first raise a warning that the behavior will be changed in the future. (please see https://github.com/pytorch/pytorch/pull/62544#issuecomment-893770955 for more context) This PR thus raises appropriate warnings and updates the documentation to show the full signature (along with a note) for `torch.nn.functional.max_poolNd` functions. **Quick links:** (_upstream_) * Documentation of [`nn.functional.max_pool1d`](https://pytorch.org/docs/1.9.0/generated/torch.nn.functional.max_pool1d.html), [`nn.functional.max_pool2d`](https://pytorch.org/docs/stable/generated/torch.nn.functional.max_pool2d.html), and [`nn.functional.max_pool3d`](https://pytorch.org/docs/stable/generated/torch.nn.functional.max_pool3d.html). (_this branch_) * Documentation of [`nn.functional.max_pool1d`](https://docs-preview.pytorch.org/62544/generated/torch.nn.functional.max_pool1d.html?highlight=max_pool1d), [`nn.functional.max_pool2d`](https://docs-preview.pytorch.org/62544/generated/torch.nn.functional.max_pool2d.html?highlight=max_pool2d#torch.nn.functional.max_pool2d), and [`nn.functional.max_pool3d`](https://docs-preview.pytorch.org/62544/generated/torch.nn.functional.max_pool3d.html?highlight=max_pool3d#torch.nn.functional.max_pool3d). cc mruberry jbschlosser Pull Request resolved: https://github.com/pytorch/pytorch/pull/62544 Reviewed By: gchanan Differential Revision: D31179038 Pulled By: jbschlosser fbshipit-source-id: 0a2c7215df9e132ce9ec51448c5b3c90bbc69030
Author
Parents
Loading