pytorch
a33d8133 - Slight cleanup of VariableBuilder giant if condition (#95471)

Commit
1 year ago
Slight cleanup of VariableBuilder giant if condition (#95471) Some of these changes are semantics preserving, some are not. Please review carefully. * Use `istype(x, y)` over `type(x) is y` * Use istype over isinstance in frozenset. If the user subclassed the type in question, we must treat it as a user defined class as it may have custom behavior * The `isinstance(value, (int, float))` condition for `wrap_unspecialized_primitive` is dead-ish; direct int/float values are caught earlier istype check. Technically however, if you subclassed int/float it would pass through, however this is almost assuredly not intended behavior Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: https://github.com/pytorch/pytorch/pull/95471 Approved by: https://github.com/Skylion007
Author
Committer
Parents
Loading