pytorch
aedffdf7 - Support for Tensor Shape Type Hint (#34595)

Commit
4 years ago
Support for Tensor Shape Type Hint (#34595) Summary: This PR is related to [https://github.com/pytorch/pytorch/issues/33953](https://github.com/pytorch/pytorch/issues/33953). I've created a directory `type_hint_tests` for the example as suggested by zou3519 [here](https://github.com/pytorch/pytorch/issues/33953#issuecomment-597716405). This directory is supposed to contain examples over which mypy will run. I've added the test in `test/test_type_hints.py`. The test can simply be invoked by ``` $ python3 test/test_type_hints.py Fail to import hypothesis in common_utils, tests are not derandomized .b'test/type_hint_tests/size.py:7: error: Tuple index out of range\ntest/type_hint_tests/size.py:8: error: Tuple index out of range\n' . ---------------------------------------------------------------------- Ran 2 tests in 13.660s OK ``` Note that I've not made the change of fixing the stub to show that the test works. The issue can be fixed by changing definition of Size in `class Size(Tuple[_int, ...]): ... ` in `/torch/__init__.pyi.in`. After changing the `Size` definition, the test passes. ``` $ python3 test/test_type_hints.py Fail to import hypothesis in common_utils, tests are not derandomized .b'' . ---------------------------------------------------------------------- Ran 2 tests in 19.382s OK ``` I will do that once i get approval from zou3519. This is an initial implementation, please provide your suggestions. Pull Request resolved: https://github.com/pytorch/pytorch/pull/34595 Differential Revision: D20441817 Pulled By: zou3519 fbshipit-source-id: 00a434adf5bca813960f4efea38aa6d6953fe85f
Author
Parents
Loading